CLN: Replace old string formatting syntax with f-strings for scripts/validate_docstrings.py #32122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for docstrings
raisadz
changed the title
| title_line = "{side} {title}{adj} {side}".format( | ||
| side=char * side_len, title=title, adj=adj | ||
| ) | ||
| title_line = f"{char * side_len} {title}{adj} {char * side_len}" |
There was a problem hiding this comment.
can you do the multiplication on the previous line
There was a problem hiding this comment.
I think this is OK for now (we have a pretty large queue) but if a sticking point can certainly be done as a follow up
WillAyd
approved these changes
Feb 20, 2020
| title_line = "{side} {title}{adj} {side}".format( | ||
| side=char * side_len, title=title, adj=adj | ||
| ) | ||
| title_line = f"{char * side_len} {title}{adj} {char * side_len}" |
There was a problem hiding this comment.
I think this is OK for now (we have a pretty large queue) but if a sticking point can certainly be done as a follow up
|
Thanks @raisadz |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff