Skip to content

TST CLN: Styler bar tests cleanup 2/3 #42504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2021

Conversation

attack68
Copy link
Contributor

cleanup 2/3 of style/test_bar.py.
Parametrises the tests for vmin/vmax clipping and widening, to test with different combinations of align.
Also adds fixtures for existing tests in the file.

@jreback jreback added the Styler conditional formatting using DataFrame.style label Jul 12, 2021
@jreback jreback added this to the 1.4 milestone Jul 12, 2021
@jreback jreback added the Testing pandas testing functions or related to the test suite label Jul 12, 2021
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. merge on green.

@attack68 attack68 merged commit f72461f into pandas-dev:master Jul 12, 2021
@attack68 attack68 deleted the styler_bar_tests_cleanup branch July 12, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Styler conditional formatting using DataFrame.style Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants