Skip to content

DEPR: 1.x deprecation cleanups #50385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Conversation

mroeschke
Copy link
Member

No description provided.

@mroeschke mroeschke added Deprecate Functionality to remove in pandas Clean labels Dec 21, 2022
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Minor note on a comment, but happy for it to be ignored and for this to be merged

Comment on lines 2046 to 2047
# Go through _setitem_single_column to get
# FutureWarning if relevant.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps the # Go through _setitem_single_column to get sentence can be removed too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Removed

@mroeschke mroeschke added this to the 2.0 milestone Dec 21, 2022
@mroeschke mroeschke merged commit bf7960d into pandas-dev:main Dec 21, 2022
@mroeschke mroeschke deleted the depr/rm/misc branch December 21, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants