Skip to content

PERF: Fix performance regression in get_loc of IntervalIndex #51339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 14, 2023
Merged

PERF: Fix performance regression in get_loc of IntervalIndex #51339

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
73da534
PERF: Fix performance regression in get_loc of IntervalIndex
phofl Feb 12, 2023
3d27f23
Switch to simple new
phofl Feb 12, 2023
11ef578
Remove
phofl Feb 12, 2023
ae8cf38
Fix mypy
phofl Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pandas/core/arrays/interval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,6 @@ def _shallow_copy(self: IntervalArrayT, left, right) -> IntervalArrayT:
"""
dtype = IntervalDtype(left.dtype, closed=self.closed)
left, right, dtype = self._ensure_simple_new_inputs(left, right, dtype=dtype)
self._validate(left, right, dtype=dtype)

return self._simple_new(left, right, dtype=dtype)

Expand Down Expand Up @@ -727,7 +726,11 @@ def __getitem__(
if np.ndim(left) > 1:
# GH#30588 multi-dimensional indexer disallowed
raise ValueError("multi-dimensional indexing not allowed")
return self._shallow_copy(left, right)
# Argument 2 to "_simple_new" of "IntervalArray" has incompatible type
# "Union[Period, Timestamp, Timedelta, NaTType, DatetimeArray, TimedeltaArray,
# ndarray[Any, Any]]"; expected "Union[Union[DatetimeArray, TimedeltaArray],
# ndarray[Any, Any]]"
return self._simple_new(left, right, dtype=self.dtype) # type: ignore[arg-type]

def __setitem__(self, key, value) -> None:
value_left, value_right = self._validate_setitem_value(value)
Expand Down