-
-
Notifications
You must be signed in to change notification settings - Fork 18.8k
BUG: fixes Arrow Dataframes/Series producing a Numpy object result #54025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @phofl do you know who I should tag for a review on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test for masked types as well? I suspect they failed before as well
Sure! I made an assumption about what you meant by the masked types After I updated the tests I noticed another potential edge case that when calling How would we want to handle this case? |
Let's ignore this case for now |
Co-authored-by: Matthew Roeschke <[email protected]>
Thanks @mcgeestocks |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Notes:
.dot()
's returned object dtype is now the result ofdtypes.cast.find_common_type()
.It's worth noting the new object's dtype's is of a higher precision but this seems line up what's expected: https://arrow.apache.org/docs/python/pandas.html#pandas-arrow-conversion