Clarify dtype parameter in read_excel #55757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mroeschke
approved these changes
Oct 30, 2023
|
Thanks @gadeatric |
rhshadrach
reviewed
Oct 30, 2023
Comment on lines
-158
to
+162
| Use `object` to preserve data as stored in Excel and not interpret dtype. | ||
| Use `object` to preserve data as stored in Excel and not interpret dtype, | ||
| which will necessarily result in `object` dtype. | ||
| If converters are specified, they will be applied INSTEAD | ||
| of dtype conversion. | ||
| If you use `None`, it will infer the dtype of each column based on the data. |
There was a problem hiding this comment.
Not a big deal, especially because the issue existed prior to this PR, but I think we should be using double backticks here. The docstrings use RST format, not markdown, and so this renders as italics rather than code highlighting.
There was a problem hiding this comment.
Thanks for the feedback! I've sent a PR with the double backticks. Let me know if I can help with anything else!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #55489
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.