BUG: Fix infer_dtype result for float with embedded pd.NA #61624
+18
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
reviewed
Jun 22, 2025
| @@ -1086,10 +1086,7 @@ def convert_dtypes( | |||
| elif ( | |||
| infer_objects | |||
| and input_array.dtype == object | |||
| and ( | |||
| isinstance(inferred_dtype, str) | |||
There was a problem hiding this comment.
To be sure, this removal is unrelated to the other change here, is that right? That is, we can remove this line on main and it won't break any tests.
rhshadrach
added
Bug
Missing-data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.Description
Fix a bug in :func:
api.types.infer_dtypereturning "mixed-integer-float" for float andpd.NAmix.Cause
This problem occurred because the existing
is_float_arrayinternally fixedskipna=False. It was solved by adding theskipnaargument.