Skip to content

CI: temporarily pin numpydoc<1.7 to unblock docstring validation (GH#61720) #61726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

evgmosme
Copy link

@evgmosme evgmosme commented Jun 27, 2025

Temporarily pin numpydoc<1.7 to unblock the docstring-validation job.

numpydoc 1.7.0 raises
AttributeError: 'getset_descriptor' object has no attribute '__module__'
inside numpydoc/validate.py, causing pandas’ Code Checks / Docstring validation
step to fail before any pandas code is run (see GH #61720).

This PR

  • pins numpydoc<1.7 in environment.yml
    (propagated to requirements-dev.txt);
  • fixes a duplicate Returns / Yields section in
    pandas/_config/config.py::option_context;
  • marks an expected warning in doc/user_guide/timeseries.rst
    with :okwarning: so Sphinx no longer treats it as an error.

Together these changes restore a green CI across all jobs.

Notes

  • All changes are limited to dev/CI and docs—no impact on end users.
  • Once an upstream fix lands in numpydoc, we’ll remove the version pin.
  • No new tests are required; a successful CI run itself demonstrates the fix.

@evgmosme evgmosme marked this pull request as ready for review June 27, 2025 22:56
@evgmosme evgmosme marked this pull request as draft June 27, 2025 23:31
@evgmosme evgmosme closed this Jun 27, 2025
@evgmosme
Copy link
Author

Superseded by #61725

@evgmosme evgmosme deleted the fix-docstr-61720 branch June 27, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: CI docstring-validation fails with AttributeError in numpydoc validate.py
1 participant