-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
CI: if no docstring, create error GL08 and don't validate - fix for numpydoc 1.9 #61744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
is this an alternative to #61725? |
Yes, and it allows us to use |
Thanks @Dr-Irv |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…umpydoc 1.9 (pandas-dev#61744) * if no docstring, create error GL08 and don't validate * add file and file_line as None if no docstring (cherry picked from commit 30a2e7f)
Backport -> #61745 |
validate_docstrings
was failing withnumpydoc
1.9 on cython methods that have no docstrings. When no docstring, there is nothing to validate.Partially addresses the CI issue mentioned in #61740