DOC: make doc build run with string dtype enabled #61864
Draft
+56
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
force-pushed
the
string-dtype-run-docs
branch
from
cb2f87d to
85bc3be
Compare
| @@ -5281,13 +5281,13 @@ Write to a parquet file. | |||
| .. ipython:: python | |||
| df.to_parquet("example_pa.parquet", engine="pyarrow") | |||
| df.to_parquet("example_fp.parquet", engine="fastparquet") | |||
| # df.to_parquet("example_fp.parquet", engine="fastparquet") | |||
There was a problem hiding this comment.
For pyarrow vs fastparquet here, we should maybe not show both constantly in each example? (just show once you can specify the engine, and then in subsequent examples showing the roundtrip just use the default engine?)
| @@ -184,7 +184,7 @@ API changes | |||
| .. ipython:: python | |||
| :okwarning: | |||
| dfc.loc[0]['A'] = 1111 | |||
| dfc.loc[0]['B'] = 1111 | |||
There was a problem hiding this comment.
The B column are already integers, so this example of chained assignment is still valid this way, but then doesn't include dtype changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is from #61722 (will be removed here after that PR is merged and this one is rebased), then subsequent commits enable errors on the doc build again and fix issues.