-
-
Notifications
You must be signed in to change notification settings - Fork 516
Example for extending Parse.User #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good improvement, but we should fix the sdk to improve how it handles the static methods.
Here's how I did it for the php-sdk: https://github.com/parse-community/parse-php-sdk/pull/394/files
and here's an example of how to fix it for the JS-SDK: https://runkit.com/arthur/static-factory-w-subclass
You up for making the changes?
_includes/js/objects.md
Outdated
Parse.Object.registerSubclass('CustomUser', CustomUser); | ||
``` | ||
|
||
In addition to queries, `logIn` and `signUp` returns subclass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will return the subclass CustomUser
Sounds like an easy fix. I didn't know about |
_includes/js/objects.md
Outdated
@@ -89,6 +89,36 @@ However, when using `extends`, the SDK is not automatically aware of your subcla | |||
Parse.Object.registerSubclass('Monster', Monster); | |||
``` | |||
|
|||
Similarly, you can `extends` `Parse.User` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should say "Similarly, you can use extends
with Parse.User
"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
@Tom-Fox1 What is |
@dplewis sorry, I don’t know, I meant to look into it but haven’t yet |
@dplewis @Tom-Fox1 I just took a look and here's what I learned... From looking at the
So the short answer is: and there's a TODO for @Tom-Fox1: take a look at _config.yml cause it has our tags for severfault (whatever that is) and stackoverlow. now i understand the doc stuff much better....:). |
@acinader Thanks for the detailed description. I understand it much better. |
parse-community/Parse-SDK-JS#722
Should we always commit
assets/js/bundle.js
?