Skip to content

Add Endpoints to view and edit Cloud Functions in dashboard #6983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 101 additions & 0 deletions spec/CloudCode.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,107 @@ describe('Cloud Code', () => {
});
});
});
const masterKeyHeaders = {
'X-Parse-Application-Id': 'test',
'X-Parse-Rest-API-Key': 'rest',
'X-Parse-Master-Key': 'test',
'Content-Type': 'application/json',
};
const masterKeyOptions = {
headers: masterKeyHeaders,
json: true,
};
it('can load cloud code file from dashboard', async done => {
const cloudDir = './spec/cloud/cloudCodeAbsoluteFile.js';
await reconfigureServer({ cloud: cloudDir });
const options = Object.assign({}, masterKeyOptions, {
method: 'GET',
url: Parse.serverURL + '/releases/latest',
});
request(options)
.then(res => {
expect(Array.isArray(res.data)).toBe(true);
const first = res.data[0];
expect(first.userFiles).toBeDefined();
expect(first.checksums).toBeDefined();
expect(first.userFiles).toContain(cloudDir);
expect(first.checksums).toContain(cloudDir);
options.url = Parse.serverURL + '/scripts/spec/cloud/cloudCodeAbsoluteFile.js';
return request(options);
})
.then(res => {
const response = res.data;
expect(response).toContain('It is possible to define cloud code in a file.');
done();
});
});

it('can load multiple cloud code files from dashboard', async done => {
const cloudDir = './spec/cloud/cloudCodeRequireFiles.js';
await reconfigureServer({ cloud: cloudDir });
const options = Object.assign({}, masterKeyOptions, {
method: 'GET',
url: Parse.serverURL + '/releases/latest',
});
request(options).then(res => {
expect(Array.isArray(res.data)).toBe(true);
const first = res.data[0];
expect(first.userFiles).toBeDefined();
expect(first.checksums).toBeDefined();
expect(first.userFiles).toContain(cloudDir);
expect(first.checksums).toContain(cloudDir);
expect(first.userFiles).toContain('spec/cloud/cloudCodeAbsoluteFile.js');
expect(first.checksums).toContain('spec/cloud/cloudCodeAbsoluteFile.js');
expect(first.userFiles).toContain('spec/cloud/cloudCodeRelativeFile.js');
expect(first.checksums).toContain('spec/cloud/cloudCodeRelativeFile.js');
done();
});
});

it('can edit cloud code file from dashboard', async done => {
const cloudDir = './spec/cloud/cloudCodeRequireFiles.js';
await reconfigureServer({ cloud: cloudDir });
const options = Object.assign({}, masterKeyOptions, {
method: 'GET',
url: Parse.serverURL + '/releases/latest',
});
let originalFile = '';
request(options)
.then(res => {
expect(Array.isArray(res.data)).toBe(true);
const first = res.data[0];
expect(first.userFiles).toBeDefined();
expect(first.checksums).toBeDefined();
expect(first.userFiles).toContain(cloudDir);
expect(first.checksums).toContain(cloudDir);
options.url = Parse.serverURL + '/scripts/spec/cloud/cloudCodeRequireFiles.js';
return request(options);
})
.then(res => {
originalFile = res.data;
let response = res.data;
expect(response).toContain(`require('./cloudCodeAbsoluteFile.js`);
response = response + '\nconst additionalData;\n';
options.method = 'POST';
options.url = Parse.serverURL + '/scripts/spec/cloud/cloudCodeRequireFiles.js';
options.body = {
data: response,
};
return request(options);
})
.then(res => {
expect(res.data).toBe('This file has been saved.');
options.method = 'POST';
options.url = Parse.serverURL + '/scripts/spec/cloud/cloudCodeRequireFiles.js';
options.body = {
data: originalFile,
};
return request(options);
})
.then(() => {
done();
});
});

it('can create functions', done => {
Parse.Cloud.define('hello', () => {
Expand Down
2 changes: 2 additions & 0 deletions spec/cloud/cloudCodeRequireFiles.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
require('./cloudCodeAbsoluteFile.js');
require('./cloudCodeRelativeFile.js');
85 changes: 85 additions & 0 deletions src/Routers/CloudCodeRouter.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import Parse from 'parse/node';
import rest from '../rest';
const triggers = require('../triggers');
const middleware = require('../middlewares');
const fs = require('fs');
const path = require('path');

function formatJobSchedule(job_schedule) {
if (typeof job_schedule.startAfter === 'undefined') {
Expand Down Expand Up @@ -53,6 +55,24 @@ export class CloudCodeRouter extends PromiseRouter {
middleware.promiseEnforceMasterKeyAccess,
CloudCodeRouter.deleteJob
);
this.route(
'GET',
'/releases/latest',
middleware.promiseEnforceMasterKeyAccess,
CloudCodeRouter.getCloudCode
);
this.route(
'GET',
'/scripts/*',
middleware.promiseEnforceMasterKeyAccess,
CloudCodeRouter.getCloudFile
);
this.route(
'POST',
'/scripts/*',
middleware.promiseEnforceMasterKeyAccess,
CloudCodeRouter.saveCloudFile
);
}

static getJobs(req) {
Expand Down Expand Up @@ -120,4 +140,69 @@ export class CloudCodeRouter extends PromiseRouter {
};
});
}
static saveCloudFile(req) {
const file = req.url.replace('/scripts', '');
const dirName = __dirname.split('lib')[0].split('node_modules')[0];
const filePath = path.join(dirName, file);
const data = req.body.data;
if (!data) {
throw new Parse.Error(Parse.Error.INTERNAL_SERVER_ERROR, 'No data to save.');
}
fs.writeFileSync(filePath, data);
return {
response: 'This file has been saved.',
};
}
static getCloudFile(req) {
const file = req.url.replace('/scripts', '');
const dirName = __dirname.split('lib')[0].split('node_modules')[0];
const filePath = path.join(dirName, file);
if (!fs.existsSync(filePath) || !fs.lstatSync(filePath).isFile()) {
throw new Parse.Error(Parse.Error.INTERNAL_SERVER_ERROR, 'Invalid file url.');
}
return {
response: fs.readFileSync(filePath, 'utf8'),
};
}
static getCloudCode(req) {
const config = req.config;
const dirName = __dirname.split('node_modules')[0];
const cloudLocation = ('' + config.cloud).replace(dirName, '');
const cloudFiles = [];
const getRequiredFromFile = (file, directory) => {
try {
const fileData = fs.readFileSync(file, 'utf8');
const requireStatements = fileData.split('require(');
for (let reqStatement of requireStatements) {
reqStatement = reqStatement.split(')')[0].slice(1, -1);
const filePath = path.join(directory, reqStatement);
if (!fs.existsSync(filePath) || !fs.lstatSync(filePath).isFile()) {
continue;
}
const requireData = fs.readFileSync(filePath, 'utf8');
const newFilePath = filePath.replace(dirName, '');
cloudFiles.push(newFilePath);
if (requireData.includes('require(')) {
getRequiredFromFile(newFilePath, path.dirname(filePath));
}
}
} catch (e) {
/* */
}
};
cloudFiles.push(cloudLocation);
getRequiredFromFile(cloudLocation, path.dirname(config.cloud));
const response = {};
for (const file of cloudFiles) {
response[file] = new Date();
}
return {
response: [
{
checksums: JSON.stringify({ cloud: response }),
userFiles: JSON.stringify({ cloud: response }),
},
],
};
}
}
1 change: 1 addition & 0 deletions src/Routers/FeaturesRouter.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export class FeaturesRouter extends PromiseRouter {
},
cloudCode: {
jobs: true,
viewCode: true,
},
logs: {
level: true,
Expand Down