Skip to content

Make sure to copy use_tagging. #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2016
Merged

Make sure to copy use_tagging. #50

merged 2 commits into from
Jan 26, 2016

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jan 26, 2016

This will fix php-cache/issues#30

@codecov-io
Copy link

Current coverage is 21.94%

Merging #50 into master will decrease coverage by -0.03% as of c433a2a

@@            master     #50   diff @@
======================================
  Files           18      18       
  Stmts          710     711     +1
  Branches         0       0       
  Methods         82      82       
======================================
  Hit            156     156       
  Partial          0       0       
- Missed         554     555     +1

Review entire Coverage Diff as of c433a2a

Powered by Codecov. Updated on successful CI builds.

@@ -37,7 +37,7 @@ protected function configure()
$this->setDescription('Flushes the given cache');
$this->addArgument('type', InputArgument::OPTIONAL, sprintf('Which type of cache do you want to clear? Valid types are: %s', implode(', ', self::VALID_TYPES)));
$this->addArgument('service', InputArgument::OPTIONAL, 'If using type "provider" you must give a service id for the cache you want to clear.');
$this->setHelp(<<<EOD
$this->setHelp(<<<'EOD'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is from styleCI. It surprised me too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird...

cryptiklemur added a commit that referenced this pull request Jan 26, 2016
Make sure to copy use_tagging.
@cryptiklemur cryptiklemur merged commit 592f9f0 into master Jan 26, 2016
@Nyholm Nyholm deleted the use_tagging branch January 26, 2016 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notice: Undefined index: use_tagging
3 participants