Skip to content

CacheFlushCommand was using features from PHP 5.6 but the lowest supp… #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2016
Merged

CacheFlushCommand was using features from PHP 5.6 but the lowest supp… #51

merged 1 commit into from
Feb 15, 2016

Conversation

iainmckay
Copy link
Contributor

Hi guys,

The lowest supported PHP version in composer.json is PHP 5.5 but CacheFlushCommand is using array constants which aren't supported until PHP 5.6.

This PR adds a fix.

@codecov-io
Copy link

Current coverage is 21.81%

Merging #51 into master will decrease coverage by -0.13% as of d5a027a

@@            master     #51   diff @@
======================================
  Files           18      18       
  Stmts          711     715     +4
  Branches         0       0       
  Methods         82      83     +1
======================================
  Hit            156     156       
  Partial          0       0       
- Missed         555     559     +4

Review entire Coverage Diff as of d5a027a

Powered by Codecov. Updated on successful CI builds.

@cryptiklemur
Copy link
Member

Thanks! Can you fix the one style issue, and then I can merge it.

@iainmckay
Copy link
Contributor Author

Done

cryptiklemur added a commit that referenced this pull request Feb 15, 2016
CacheFlushCommand was using features from PHP 5.6 but the lowest supp…
@cryptiklemur cryptiklemur merged commit 71adf22 into php-cache:master Feb 15, 2016
@cryptiklemur
Copy link
Member

Thanks :)

@Nyholm
Copy link
Member

Nyholm commented Feb 15, 2016

I did not know. Thank you!

@iainmckay
Copy link
Contributor Author

I think most sane folk are on 5.6 now so it's pretty easy to miss.

It could be worth setting your IDE/Editor's minimum PHP version to 5.5 while working on this. I use PhpStorm and it highlights these sorts of issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants