[CI] Migrate to GH actions #399
Conversation
ostrolucky
force-pushed
the
gh-actions
branch
3 times, most recently
from
5e3de0c to
76ba153
Compare
ostrolucky
force-pushed
the
gh-actions
branch
2 times, most recently
from
549b725 to
cd875f3
Compare
|
Thanks for the PR. Please see my suggestions. |
|
Thanks for review @sagikazarmark. I would say subjective suggestions, but I've implemented them. Just FYI, I took most of the structure over from https://github.com/doctrine/DoctrineBundle/tree/2.4.x/.github/workflows |
|
we should adjust the README.md as well, to have the badge and link from github actions rather than travis. the badge url is https://github.com/php-http/HttplugBundle/actions/workflows/continuous-integration.yml/badge.svg and i would link that to https://github.com/php-http/HttplugBundle/actions/ |
|
Thanks for making the changes @ostrolucky ! Yes, I guess they are subjective, but that's how things are implemented in the projects I maintain (Twirp, Guzzle, MoneyPHP) and they worked well for the last couple years, so I prefer keeping them consistent (unless there are reasons not to of course). |
No coverage for now, can come later
|
All good? |
|
should we put an editorconfig based on https://github.com/twirphp/twirp/blob/master/.github/.editorconfig into the .github folder? we have those at top level in our company projects and they are useful to help with consistent whitespace (and explicitly define the rules) |
|
Rather top level. But separate changeset please |
|
Having a top level editorconfig file is always a good idea and we should already have those in all php-http repos. Having one in .github helps configuring how editors should behave within that folder. I'd say 4 spaces should be the default everywhere, but GitHub workflows are indentated with 2 spaces everywhere (docs, examples), so limiting 2 spaces to .github makes sense. |
No coverage for now, can come later