PHP 7.2: Failure evaluating code: is_resource($handle)

[samuelnogueira]

In src/PromiseCore.php:79, there are 2 assertions as string:

        assert('is_resource($handle)');
        assert('get_resource_type($handle) === "curl"');

This behavior is deprecated in PHP 7.2 (see http://php.net/manual/en/function.assert.php).

[samuelnogueira]

Since this library supports both PHP 5 and 7, and assertions as language construct exist only since version 7.0, I'm not sure what's the best course of action here, should the library stop supporting PHP 5? Or should assertions be rewritten as if (...) { throw exception }?

[samuelnogueira]

@mekras I didn't mean to overstep, I just already had a working fix that I would like to share with you and the other contributors if it somehow saves you guys work.

[Nyholm]

No worries. I would say this is perfect behavior to write an issue and then create a fix for it. I promise @mekras is super happy that you added a PR.

[mekras]

Version 1.7.1 released.