update pack to install psr-18 client #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
commented
Jan 24, 2019
Nyholm
requested changes
Jan 25, 2019
|
we need to tag curl-client and client-common before we release this. do we need to tag a release of the pack for flex to see it or does flex look at master? |
|
Yes. We need to tag a release on this package. But I will still wait before I merge this. |
|
Bump.. @Nyholm can this be merged? |
Nyholm
approved these changes
Apr 8, 2019
|
I tested and it does not work with guzzle/psr17. I added nyholm/psr7 because it supports psr17. Thank you @MrNicodemuz |
|
And thank you @dbu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do we need to add something for the psr-17 factories or where do those come from?