Skip to content

remove request/response value objects from log context #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

remove request/response value objects from log context #20

wants to merge 2 commits into from

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Feb 9, 2022 •
edited by dbu
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets related to #16
Documentation -
License MIT

@ro0NL ro0NL mentioned this pull request Feb 9, 2022
Closed
@krewetka
Copy link

krewetka commented Feb 9, 2022 •
edited
Loading

In my opinion you cannot say it fixed #16 when the reported problem there is Request and response in context always empty and your MR is removing it from context.

The other thing is what we discussed inside the thread there but really hard to say it fixes problem reported by author :)

I am not against this MR by any means, just description is not really accurate.

dbu
dbu approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the MR. i think this cleans things up nicely.

i agree that this does not completely solve #16, i am leaving that open.

i fixed the CS issue and added a note in the changelog, then merged on the CLI.

@dbu dbu closed this Feb 10, 2022
@ro0NL ro0NL deleted the log-context branch February 10, 2022 10:05
@ro0NL ro0NL mentioned this pull request Feb 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ro0NL @krewetka @dbu