Skip to content

Update dependency for Symfony 4. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 29, 2017
Merged

Update dependency for Symfony 4. #4

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8157dd1
Update dependency for Symfony 4.
Oct 22, 2017
584ecfb
Add Symfony 4 to travis build matrix.
Oct 22, 2017
a6d3ad2
Add dev flag to Symfony 4 build.
Nov 24, 2017
e0f819c
Adding dev-flag should not be necessary as composer.json allows for d…
Nov 25, 2017
0deb9cd
Restructure .travis.yml
Nov 27, 2017
c8525ca
Add SYMFONY_VERSION to build allowed failed.
Nov 27, 2017
0c69bee
Remove unused exclude and refine requirement for 3.x LTS.
Nov 27, 2017
670faff
Add missing Symfony version.
Nov 27, 2017
92031a3
Separate matrix sections with comments.
Nov 27, 2017
e97b447
Make sure we install sf4
Nyholm Nov 29, 2017
588a308
typo
Nyholm Nov 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ php:
- 5.5
- 5.6
- 7.0
- 7.1
- hhvm

env:
Expand All @@ -30,6 +31,8 @@ matrix:
include:
- php: 5.4
env: COMPOSER_FLAGS="--prefer-stable --prefer-lowest" COVERAGE=true TEST_COMMAND="composer test-ci" SYMFONY_VERSION=2.7.*
- php: 7.1
env: SYMFONY_VERSION=4.0.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be env: SYMFONY_VERSION=4.0.*@dev since there is no stable release yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but this will still break, because phpspec will complain: https://github.com/phpspec/phpspec/blob/master/composer.json#L29-L33

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can use COMPOSER_FLAGS="--minimum-stability=dev" or something like that.

exclude:
- php: 5.4
env: SYMFONY_VERSION=3.0.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exclude role does not match any entry from the matrix above.

Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
],
"require": {
"php": ">=5.4",
"symfony/stopwatch": "^2.7|^3.0",
"symfony/stopwatch": "^2.7|^3.0|^4.0",
"php-http/client-common": "^1.1"
},
"require-dev": {
Expand Down