Update libxml2 docs relating to entity validation #1409
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds warning that the `LIBXML_DTD_VALID` constant is also susceptible to XXE exploit, and that the use of `LIBXML_DTDATTR` or `LIBXML_DTDLOAD` constants will cause external entity fetching. Also adds a note to the deprecated libxml_disable_entity_loader function to note that LIBXML_NONET will prevent loading of external entities. Prior to deprecation of the `libxml_disable_entity_loader` function, the use of this function prevented both XXE via DTD parsing, and fetching of external entities as specified by any of the above constants. Fixes phpGH-1408.
nielsdos
requested changes
Aug 2, 2023
nielsdos
added a commit
to nielsdos/doc-en
that referenced
this pull request
Nov 11, 2024
…warn about constants which will override the new default behaviour Based on stale PR phpGH-1409. Closes phpGH-1409. Closes phpGH-1408. Co-authored-by: Andrew Nicols <[email protected]>
nielsdos
added a commit
to nielsdos/doc-en
that referenced
this pull request
Nov 11, 2024
…warn about constants which will override the new default behaviour Based on stale PR phpGH-1409. Closes phpGH-1409. Closes phpGH-1408. Co-authored-by: Andrew Nicols <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds warning that the
LIBXML_DTD_VALIDconstant is alsosusceptible to XXE exploit, and that the use of
LIBXML_DTDATTRorLIBXML_DTDLOADconstants will cause external entity fetching.Also adds a note to the deprecated libxml_disable_entity_loader function
to note that LIBXML_NONET will prevent loading of external entities.
Prior to deprecation of the
libxml_disable_entity_loaderfunction, theuse of this function prevented both XXE via DTD parsing, and fetching of
external entities as specified by any of the above constants.
Fixes GH-1408.