Sync exif dependency on mbstring extension as optional #3793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The required dependency on mbstring extension in exif was removed via php/php-src@755c2cd which made the mbstring extension optional dependency. Update for the PHP build system: php/php-src#16062
Girgias
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The required dependency on mbstring extension in exif was removed via php/php-src@755c2cd which made the mbstring extension optional dependency.
Also the exif extension uses the
ZEND_MOD_OPTIONALto define the dependency on mbstring extension so it already loads the extensions in this case properly (meaning: there's no need to mention that mbstring must be loaded before the exif in php.ini).Update for the PHP build system:
php/php-src#16062