Skip to content

weakreference.xml Give more details about the WeakReferences #3976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

mmalferov
Copy link
Member

Maybe we should describe in more detail the features of weak references?

I am not sure about the correctness of the wording, but the scant information about WeakReference needs to be supplemented

Maybe we should describe in more detail the features of weak references?

I am not sure about the correctness of the wording, but the scant information about WeakReference needs to be supplemented
Copy link
Member

@jimwins jimwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also add something on WeakReference and an example to language/references.xml

@mmalferov
Copy link
Member Author

It's a good idea. Probably, the best section for WR it is a Unsetting References, because the peculiarity of WR is precisely how they behave when destroying variables that store a pointer to an object

I am not the best author, so if you help me write a description, I can add another commit to this PR (or, if it would be better, in different PR) with changes in the file 'language/references.xml' ;)

@Girgias
Copy link
Member

Girgias commented Nov 4, 2024

I think opening an issue about mentioning WeakReference/WeakMap in the language/reference.xml page might be better to track this.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the English grammar rules around semicolons, so will need someone else to judge if this is correct.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Girgias Girgias merged commit cd391e6 into php:master Nov 8, 2024
2 checks passed
@mmalferov mmalferov deleted the patch-91 branch January 20, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants