-
Notifications
You must be signed in to change notification settings - Fork 809
weakreference.xml Give more details about the WeakReferences #3976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Maybe we should describe in more detail the features of weak references? I am not sure about the correctness of the wording, but the scant information about WeakReference needs to be supplemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should also add something on WeakReference
and an example to language/references.xml
Co-authored-by: Jim Winstead <[email protected]>
It's a good idea. Probably, the best section for WR it is a Unsetting References, because the peculiarity of WR is precisely how they behave when destroying variables that store a pointer to an object I am not the best author, so if you help me write a description, I can add another commit to this PR (or, if it would be better, in different PR) with changes in the file 'language/references.xml' ;) |
I think opening an issue about mentioning WeakReference/WeakMap in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the English grammar rules around semicolons, so will need someone else to judge if this is correct.
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Maybe we should describe in more detail the features of weak references?
I am not sure about the correctness of the wording, but the scant information about WeakReference needs to be supplemented