Skip to content

Create stub for request_parse_body() #4108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 27, 2024
Merged

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Nov 20, 2024

@iluuu1994 I created a stub, if you could document this. :)

@Girgias Girgias added this to the PHP 8.4 milestone Nov 20, 2024
@Girgias Girgias changed the title Create stub Create stub for request_parse_body() Nov 20, 2024
@iluuu1994
Copy link
Member

Thank you Gina! Can you review this? (Can't add you as a reviewer since you created the PR).

Copy link
Member Author

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, the main one being the indentation :)

@iluuu1994
Copy link
Member

Thank you @Girgias! Hopefully it looks good now.

Copy link
Member Author

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the last review comments, as exceptions should be described in a dedicated error section.

If you are happy with the wording, feel free to commit and merge :)

@iluuu1994 iluuu1994 merged commit 4bf789e into php:master Nov 27, 2024
2 checks passed
@iluuu1994
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants