-
Notifications
You must be signed in to change notification settings - Fork 809
Create stub for request_parse_body() #4108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b0d7e02
to
8ec284a
Compare
Thank you Gina! Can you review this? (Can't add you as a reviewer since you created the PR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, the main one being the indentation :)
Thank you @Girgias! Hopefully it looks good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the last review comments, as exceptions should be described in a dedicated error section.
If you are happy with the wording, feel free to commit and merge :)
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Thank you! |
@iluuu1994 I created a stub, if you could document this. :)