password_hash: Update for PHP 8.4 #4455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the `password_hash()` documentation for the updated default cost of bcrypt in PHP 8.4. It also performs some general cleanup.
nielsdos
approved these changes
Feb 19, 2025
Girgias
reviewed
Feb 20, 2025
| If omitted, a default value of <literal>10</literal> will be used. This is a good | ||
| baseline cost, but you may want to consider increasing it depending on your hardware. | ||
| If omitted, a default value of <literal>12</literal> will be used. This is a good | ||
| baseline cost, but you may want to consider adjusting it depending on your hardware. |
There was a problem hiding this comment.
Maybe at the same time remove personalization (i.e. usage of "you")?
There was a problem hiding this comment.
It's all over the document. I'll do this in a follow-up.
|
I think constants.xml needs to be updated too? doc-en/reference/password/constants.xml Line 46 in 51ea49d |
Good find, thanks. Fixed in 66aff41 |
KentarouTakeda
added a commit
to php/doc-ja
that referenced
this pull request
Mar 9, 2025
* password_hash: Update for PHP 8.4 * password_*(): Sync with `password_hash()` * `password_hash()` のサンプルコードも原文の更新に追随 --------- Co-authored-by: 武田 憲太郎 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
password_hash()documentation for the updated default cost of bcrypt in PHP 8.4. It also performs some general cleanup.