Avoid extra string allocation in get_full_env() #1382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can pass the key directly to add_assoc_str().
nielsdos
commented
Feb 17, 2025
frankenphp.c
Outdated
|
|
||
| // release the key string | ||
| zend_string_release(key_str); | ||
| add_assoc_str(track_vars_array, key.data, val_str); |
There was a problem hiding this comment.
You can even use add_assoc_str_ex to avoid a strlen call, as I suppose that we length of the key would be the same as strlen on this as there won't be any NUL bytes. Or am I mistaken here?
There was a problem hiding this comment.
Alright. I pushed that now, as a separate commit (it's a habit so it makes it clearer on GitHub what has changed since last review/remark, I can adapt to what you're used as convention as well but this is what I do in php-src).
On approve I can either squash it for you and use the conventional commit format. Just let me know.
There was a problem hiding this comment.
We do the same thing, and we usually squash for you on merge.
dunglas
approved these changes
Feb 17, 2025
|
Thanks @nielsdos! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can pass the key directly to add_assoc_str().