Skip to content

Call opcache_reset PHP function directly #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 24, 2025

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Feb 20, 2025

Combined with #1398 this should allow the removal of frankenphp_execute_php_function

@AlliBalliBaba
Copy link
Contributor

Cgo has a weird bug where it will sometimes throw a warning if you have a function without return value and parameters.

This will throw a warning:
void frankenphp_reset_opcache(void)

This will not:
int frankenphp_reset_opcache(void)

@dunglas dunglas force-pushed the reset-opcache-simplify branch from b35bf56 to 6ae074b Compare March 22, 2025 12:22
@dunglas dunglas marked this pull request as ready for review March 24, 2025 09:18
@dunglas dunglas merged commit 3701516 into php:main Mar 24, 2025
43 checks passed
@dunglas
Copy link
Member

dunglas commented Mar 24, 2025

Thanks @Girgias

@Girgias Girgias deleted the reset-opcache-simplify branch March 24, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants