refactor: removes context on the C side #1404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlliBalliBaba
changed the title
AlliBalliBaba
changed the title
dunglas
reviewed
Feb 24, 2025
|
Will this impact Performance? |
dunglas
requested changes
Feb 26, 2025
|
@Reinhard-Berger this will not affect performance |
…s-refactor-context # Conflicts: # frankenphp.c # phpthread.go # threadworker.go
|
@dunglas let me know once you're ready to merge this, I have some small follow-ups that this PR enables. |
|
We can also wait for #1376, pretty sure there will be some small conflicts. |
dunglas
approved these changes
Mar 8, 2025
Yes. Slow down on the major refactors :p I have a few too, but just been waiting on things to stabilize. Seriously good work though! |
withinboredom
approved these changes
Mar 9, 2025
dunglas
deleted the
feat/auto-scale-clock-time-fc-better-timeouts-refactor-context
branch
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this PR is a refactor of the
FrankenPHPContext. I noticed that having a context on both the C and the go side can be pretty confusing and error prone. Especially considering that fatal errors (like timeouts) will make a worker just jump to the end of a script. This PR removes most of the context on the C side and decouples some components fromnet/httpby passing the context in channels.Having minimal thread-local context on the C side should also make it easier to execute PHP directly in go threads in the future.