fix: log worker failures #1437
Merged
fix: log worker failures #1437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Mar 10, 2025
|
Good improvement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 small issues that also came up in #1421.
I've noticed before that any error that is thrown during a worker start is not actually logged anywhere. While php in dev mode will log any fatal errors to stderr, in the
dunglas/frankenphpimage this is actually not the case.There exists logic for
logger.Info()to output everything during worker startup, but that logic never gets triggered since PHP will not attempt to callub_writeif sending headers fails. This PR fixes that by 'faking' a successful sending of headers.This PR also makes workers fail everytime if
frankenphp_handle_requesthas not been reached.