feat: dequeue worker request on timeout #1540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tolsee
commented
May 7, 2025
|
Not sure, why the builds are failing. |
|
Seems like this command fails since it tries to update go to |
|
It would be nice to automatically use the latest patch version. |
Tolsee
changed the title
max_wait_time
|
@AlliBalliBaba What do you think about the actual solution? |
dunglas
approved these changes
May 9, 2025
AlliBalliBaba
approved these changes
May 9, 2025
| rw.(http.Flusher).Flush() | ||
|
|
||
| if f, ok := rw.(http.Flusher); ok { | ||
| f.Flush() |
There was a problem hiding this comment.
Suggested change
| f.Flush() | |
| f.Flush() |
| @@ -225,6 +225,7 @@ func (worker *worker) handleRequest(fc *frankenPHPContext) { | |||
| case scaleChan <- fc: | |||
| // the request has triggered scaling, continue to wait for a thread | |||
| case <-timeoutChan(maxWaitTime): | |||
| metrics.DequeuedWorkerRequest(worker.name) | |||
There was a problem hiding this comment.
Looks good 👍, you can probably also add this line in threadregular.go (for non-worker requests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes (#1539 (comment))