Skip to content

ext/bcmath: Optimize bcdiv processing #14660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Aug 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
5992fef
Used BC_VECTOR for division to speed up calculations
SakiTakamachi Jul 17, 2024
3e3750e
Fixed a comment
SakiTakamachi Jul 17, 2024
d34e9df
Fixed comments
SakiTakamachi Jul 17, 2024
c56d0f3
Correction of line break position
SakiTakamachi Jul 17, 2024
9177d4c
Changed n1 to numerator and n2 to divisor
SakiTakamachi Jul 17, 2024
bf0f88d
Changed the naming of divided and divider
SakiTakamachi Jul 17, 2024
0102def
Delete unnecessary i and j definitions
SakiTakamachi Jul 18, 2024
523b3dc
Fixed comments
SakiTakamachi Jul 18, 2024
62a0ecf
use <=>
SakiTakamachi Jul 18, 2024
93e34b7
Char made const
SakiTakamachi Jul 18, 2024
8972f58
Fixed a comment
SakiTakamachi Jul 18, 2024
960fc8e
Fixed a comment
SakiTakamachi Jul 18, 2024
5aeec23
Fixed a comment
SakiTakamachi Jul 18, 2024
9196685
Fixed a comment
SakiTakamachi Jul 18, 2024
5b70842
Fixed var names
SakiTakamachi Jul 18, 2024
28bf55d
Fixed confusing comments
SakiTakamachi Jul 18, 2024
eeb72ca
Fixed a comment
SakiTakamachi Jul 18, 2024
401ad24
Fixed a comment
SakiTakamachi Jul 18, 2024
e0b83ad
Fixed vector to vectors
SakiTakamachi Jul 18, 2024
06b6f56
Removed unnecessary comments
SakiTakamachi Jul 18, 2024
dfb1e4f
Calculate numerator_high_part first
SakiTakamachi Jul 18, 2024
859a9db
Fixed a comment
SakiTakamachi Jul 18, 2024
f24a72b
Fixed a comment
SakiTakamachi Jul 19, 2024
3cca73d
Added a comment that using restoring division
SakiTakamachi Jul 20, 2024
bd9b1bb
Fixed a comment
SakiTakamachi Jul 20, 2024
f07abf4
Added a blank line
SakiTakamachi Jul 20, 2024
8ca6f1e
Fixed a comment
SakiTakamachi Jul 20, 2024
ffb6e8e
Fixed var names
SakiTakamachi Jul 20, 2024
72f7f3a
Fixed a comment
SakiTakamachi Jul 22, 2024
b88956d
Fixed a comment
SakiTakamachi Jul 22, 2024
3f3679a
Fixed a comment
SakiTakamachi Jul 22, 2024
71a3ba3
Fixed a comment
SakiTakamachi Jul 22, 2024
68bcff9
Renamed var names
SakiTakamachi Jul 22, 2024
d80c452
Added a early return case
SakiTakamachi Jul 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/bcmath/libbcmath/src/bcmath.h
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ bc_num bc_multiply(bc_num n1, bc_num n2, size_t scale);
*(result) = mul_ex; \
} while (0)

bool bc_divide(bc_num n1, bc_num n2, bc_num *quot, int scale);
bool bc_divide(bc_num n1, bc_num n2, bc_num *quot, size_t scale);

bool bc_modulo(bc_num num1, bc_num num2, bc_num *resul, size_t scale);

Expand Down
Loading
Loading