-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix typo #15780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo #15780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, build systems don't know plural very well. Looks ok to me, since there are a bit limited options with one-liners here.
Otherwise, possible simpler output would be also something like this: STDOUT.WriteLine('The following ' +
INVALID_CONFIG_ARGS.length > 1 ? 'argument is' : 'arguments are' +
' invalid, and therefore ignored:'); |
Besides that, how should CFLAGS It seems Not sure about the rest. Maybe you know that for nmake on Windows @petk. |
It depends why you'd need to set these. MSVC directly doesn't have POSIX threads. Neither the gnu99 std flag. I think that there is no need to set the C99 standard with a flag for MSVC. Neither something like gnu99 std flag for GNU extensions. There is C11 though -std:c11... |
Ok, that helps a bit, but now I get many compilation errors like error It seems I miss something to compile a GNU C90 PHP-extension for / on Windows. |
I wish I knew what the issue is here but I'm really not sure. This looks something in the C code of the extension. It depends on where the errors come from. |
Co-authored-by: Peter Kokot <[email protected]>
No description provided.