Skip to content

Fix typo #15780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 7, 2024
Merged

Fix typo #15780

merged 4 commits into from
Sep 7, 2024

Conversation

DanielRuf
Copy link
Contributor

No description provided.

Copy link
Member

@petk petk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, build systems don't know plural very well. Looks ok to me, since there are a bit limited options with one-liners here.

@petk
Copy link
Member

petk commented Sep 7, 2024

Otherwise, possible simpler output would be also something like this:

STDOUT.WriteLine('The following ' +
	INVALID_CONFIG_ARGS.length > 1 ? 'argument is' : 'arguments are' +
	' invalid, and therefore ignored:');

@DanielRuf
Copy link
Contributor Author

DanielRuf commented Sep 7, 2024

Besides that, how should CFLAGS -Werror -Wall -O3 -pthread -std=gnu90 be for MSVC cl.exe?

It seems -Werror becomes /WX.
-Wall becomes /Wall.

Not sure about the rest. Maybe you know that for nmake on Windows @petk.

@petk
Copy link
Member

petk commented Sep 7, 2024

It depends why you'd need to set these. MSVC directly doesn't have POSIX threads. Neither the gnu99 std flag. I think that there is no need to set the C99 standard with a flag for MSVC. Neither something like gnu99 std flag for GNU extensions. There is C11 though -std:c11...

@DanielRuf
Copy link
Contributor Author

Ok, that helps a bit, but now I get many compilation errors like error C2146: syntax error: missing ')' before identifier 'error_lineno' for const uint error_lineno,.

It seems I miss something to compile a GNU C90 PHP-extension for / on Windows.

@petk
Copy link
Member

petk commented Sep 7, 2024

Ok, that helps a bit, but now I get many compilation errors like error C2146: syntax error: missing ')' before identifier 'error_lineno' for const uint error_lineno,.

It seems I miss something to compile a GNU C90 PHP-extension for / on Windows.

I wish I knew what the issue is here but I'm really not sure. This looks something in the C code of the extension. It depends on where the errors come from.

Co-authored-by: Peter Kokot <[email protected]>
@petk petk merged commit dfe6c13 into php:master Sep 7, 2024
10 checks passed
@DanielRuf DanielRuf deleted the patch-1 branch September 7, 2024 14:43
@DanielRuf DanielRuf restored the patch-1 branch September 20, 2024 15:45
@DanielRuf DanielRuf deleted the patch-1 branch September 20, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants