[RFC] Final Property Promotion

[DanielEScherzer]

https://wiki.php.net/rfc/final_promotion

[TimWolla]

This does not appear to be explicitly specified in the RFC and is a language change. I'm not sure this is an appropriate bugfix for 8.4.

[TimWolla]

/cc @Crell

[iluuu1994]

This came up, and there were some concerns it could imply const parameters as in Java. So we just left it out.

[iluuu1994]

So no, this is not a bug. If you think final should be a promoted keyword, please open a new discussion on the mailing list.

[mvorisek]

Suggested change

	class B extends A {
	public $prop { get {} set {} }
	}
	class B extends A {
	public $prop = 5
	}

Suggested change

	class B extends A {
	public $prop { get {} set {} }
	}
	class B extends A {
	public function __construct(
	public $prop
	) {}
	}

Suggested change

	class B extends A {
	public $prop { get {} set {} }
	}
	class B extends A {
	public function __construct(
	$prop
	) {}
	}

Is this allowed after this PR? If yes, is it tested?

[DanielEScherzer]

GitHub's display is a bit confusing - are you suggesting that the code be

class B extends A {
    $prop
}

? That isn't valid PHP

[mvorisek]

(edited)

[DanielEScherzer]

class B extends A {
    public function __construct(
        $prop
    ) {}
}

doesn't involve property promotion

[mvorisek]

It does in A class and I would like to get this tested.

[DanielEScherzer]

I added more tests to confirm that there isn't an issue with this

[jorgsowa]

    public function __construct( $p9 ) {}

It would be good to test also the case without the final property in the constructor.

[DanielEScherzer]

Done

[DanielEScherzer]

Any more reviewers? If not I'll probably merge this next week

[iluuu1994]

Only nits, the implementation looks correct. Thanks @DanielEScherzer!

[TimWolla]

Don't forget to also add NEWS before merging.