Skip to content

Fix GH-14937: Bison parser generates different zendtokentype constants #18861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: PHP-8.3
Choose a base branch
from
Open

Fix GH-14937: Bison parser generates different zendtokentype constants #18861

wants to merge 1 commit into from

Conversation

adoy
Copy link
Member

@adoy adoy commented Jun 16, 2025

When merged upstream this will result in this for 8.4 : https://github.com/adoy/php-src/pull/4/files

@adoy adoy requested review from bukka and derickr June 16, 2025 15:07
DanielEScherzer
DanielEScherzer approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@DanielEScherzer DanielEScherzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, maybe add a comment that we need to ensure there are numbers with a reference to the bug report?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielEScherzer DanielEScherzer DanielEScherzer approved these changes

@bukka bukka Awaiting requested review from bukka

@derickr derickr Awaiting requested review from derickr

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adoy @DanielEScherzer