Skip to content

ext/tidy: zend_parse_parameters_none -> ZEND_PARSE_PARAMETERS_NONE macro #18913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2025
Merged

ext/tidy: zend_parse_parameters_none -> ZEND_PARSE_PARAMETERS_NONE macro #18913

merged 1 commit into from
Jun 22, 2025
+2 −6

Conversation

devnexen
Copy link
Member

a bit less than 3% code size gain.

nielsdos
nielsdos approved these changes Jun 22, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you measure the code size gain? Looking at the definitions of these two macros show that they're pretty much the same thing.

@devnexen
Copy link
Member Author

Just looked at tidy object compilation unit.

@devnexen devnexen merged commit 01c3001 into php:master Jun 22, 2025
9 checks passed
@devnexen devnexen deleted the tidy_parse_none branch June 22, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

Assignees
No one assigned
Labels
Extension: tidy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @nielsdos