Skip socket sendrecv test (WIN32) not for Windows

[mizunashi-mana]

This seems to be for Unix test.
And, https://github.com/php/php-src/blob/8021e0f5dcc52af60d1b1b823c732e22a390d48a/ext/sockets/tests/socket_sendrecvmsg_multi_msg.phpt is for Windows, right?

So, we should skip the test for Windows on macOS or Linux.

[petk]

Hello, thanks for all the patches @mizunashi-mana keeping tests in working condition is great.

Worth noting that this one has been previously changed to OS agnostic testing via 2f70038#diff-7e882b334d4823080a099828b9f9a16d

It seems that this test can be run under Windows after all, as it also says in the comment...
cc @carusogabriel

[mizunashi-mana]

Additionally, this test fails on macOS because IPV6_RECVPKTINFO is not defined:

php-src/ext/sockets/sendrecvmsg.c

Line 36 in 49a4e69

#define IPV6_RECVPKTINFO IPV6_PKTINFO

. The Unix test has IPV6_RECVPKTINFO test logic.

[petk]

Just thinking out loud, wouldn't it be better to filter it using it the PHP 7.2+ constant PHP_OS_FAMILY something like this:

if (PHP_OS_FAMILY === 'Darwin') {
    die('skip non macOS test');
}

[petk]

Worth noting that ext/sockets/tests/socket_sendrecvmsg_multi_msg.phpt is passing on Unix and Windows boxes. So it's failing only on macOS probably...

[cmb69]

Just thinking out loud, wouldn't it be better to filter it using it the PHP 7.2+ constant PHP_OS_FAMILY

Sounds reasonable. If we do it, than we should also update the documentation.

[carusogabriel]

Sounds reasonable. If we do it, than we should also update the documentation.

Thanks for share this link @cmb69, there's some stuff I'd like to put into there and I didn't even know about it.

[mizunashi-mana]

Hmm... This may not be the mistake of test, and be the bug of PHP...

We should add fallback for macOS by defining __APPLE_USE_RFC_3542 when we include in.h.

See also:

• macOS not fully supported chrysn/aiocoap#69
• https://bugs.ruby-lang.org/issues/8517
• add pktinfo consts and structs for linux and apple rust-lang/libc#980
• https://opensource.apple.com/source/xnu/xnu-4570.41.2/bsd/netinet6/in6.h.auto.html

[mizunashi-mana]

I reported on https://bugs.php.net/bug.php?id=77136 . May I close this PR?

[nikic]

Closing this as #3663 has landed, which also fixes this issue, if I understood correctly.