-
Notifications
You must be signed in to change notification settings - Fork 563
First stab at a prototype for revamping the download instructions page #1277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Regression report for commit 44c91c2 is at https://web-php-regression-report-pr-1277.preview.thephp.foundation |
🚀 Preview for commit 44c91c2 can be found at https://web-php-pr-1277.preview.thephp.foundation |
<div class="example"><div class="example-contents screen"><pre> | ||
sudo apt -y install software-properties-common | ||
sudo add-apt-repository ppa:ondrej/php | ||
sudo apt update | ||
sudo apt install php{$version} | ||
</pre></div></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using PPAs is Ubuntu-specific. For Debian the repository should be set up as per: https://packages.sury.org/php/README.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we need to work on all of these. And probably also stick them in files.
<div class="example"><div class="example-contents screen"><pre> | ||
sudo apt -y install software-properties-common | ||
sudo add-apt-repository ppa:ondrej/php | ||
sudo apt update | ||
sudo apt install php{$version} | ||
</pre></div></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we need to work on all of these. And probably also stick them in files.
'php82' => '8.2', | ||
'php81' => '8.1', | ||
default => '8.4' | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "routing" needs to be more clever, likely.
<?= option('osvariant', 'linux-rpm-redhat', 'RedHat'); ?> | ||
<?= option('osvariant', 'osx-latest', 'Latest'); ?> | ||
<?= option('osvariant', 'windows-wsl', 'with WSL'); ?> | ||
<?= option('osvariant', 'windows-normal', 'without WSL'); ?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prefixes are important here for disabling/enabling based on OS.
Superseded by #1287 |
No description provided.