Skip to content

Constant case #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Constant case #537

wants to merge 2 commits into from

Conversation

MathiasReker
Copy link
Contributor

The PHP constants true, false, and null MUST be written using the correct casing.

@MathiasReker
Constant case
da943a6 
The PHP constants true, false, and null MUST be written using the correct casing.
@cmb69
Copy link
Member

cmb69 commented Jun 17, 2022

The PHP constants true, false, and null MUST be written using the correct casing.

RIght. However, the correct casing depends on the coding style.

@cmb69 cmb69 added the CS label Jun 17, 2022
localheinz
localheinz reviewed Jun 27, 2022
View reviewed changes
Copy link
Contributor

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@localheinz
Copy link
Contributor

For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.8.0/doc/rules/casing/constant_case.rst.

@localheinz localheinz mentioned this pull request Jul 15, 2022
Merged
2 tasks
@cmb69
Copy link
Member

cmb69 commented Jul 15, 2022

Closing in favor of #660 which just has been merge. Thanks for the PR nonetheless!

@cmb69 cmb69 closed this Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localheinz localheinz localheinz left review comments

Assignees
No one assigned
Labels
CS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MathiasReker @cmb69 @localheinz