Skip to content

Single blank line at eof #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2022
Merged

Single blank line at eof #541

merged 1 commit into from
Jun 17, 2022

Conversation

MathiasReker
Copy link
Contributor

A PHP file without end tag must always end with a single empty line feed.

@MathiasReker
Single blank line at eof
bb29854 
A PHP file without end tag must always end with a single empty line feed.
kamil-tekiela
kamil-tekiela approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@kamil-tekiela kamil-tekiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but one of your other PRs did the exact opposite. Could you not make a single PR with all the changes and also commit the CS-fixer file?

@localheinz
Copy link
Contributor

@kamil-tekiela @MathiasReker

How do you feel about adding an .editorconfig?

root = true

[*]
insert_final_newline = true

localheinz
localheinz reviewed Jun 17, 2022
View reviewed changes
Copy link
Contributor

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cmb69
Copy link
Member

cmb69 commented Jun 17, 2022

I think an .editorconfig would be less controversial that a CS-fixer configuration.

@cmb69 cmb69 merged commit 855860a into php:master Jun 17, 2022
@cmb69
Copy link
Member

cmb69 commented Jun 17, 2022

Thank you!

@localheinz localheinz mentioned this pull request Jun 17, 2022
Merged
1 task
@localheinz
Copy link
Contributor

For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.8.0/doc/rules/whitespace/single_blank_line_at_eof.rst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localheinz localheinz localheinz left review comments

@kamil-tekiela kamil-tekiela kamil-tekiela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MathiasReker @localheinz @cmb69 @kamil-tekiela