Fix: Move class into src/
#581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
commented
Jun 28, 2022
src/news/Entry.php
Outdated
| @@ -11,7 +11,7 @@ class Entry { | |||
| ]; | |||
|
|
|||
| const WEBROOT = "https://www.php.net"; | |||
| const PHPWEB = __DIR__ . '/../'; | |||
| const PHPWEB = __DIR__ . '/../../'; | |||
There was a problem hiding this comment.
Run
bin/createNewsEntryand
bin/createReleaseEntryto confirm that this still works as expected.
localheinz
commented
Jun 28, 2022
bin/createNewsEntry
Outdated
| @@ -2,8 +2,9 @@ | |||
| <?php | |||
| PHP_SAPI == 'cli' or die("Please run this script using the cli sapi"); | |||
|
|
|||
| require(__DIR__ . '/../include/news_entry.inc'); | |||
| use phpweb\news\Entry; | |||
| require_once __DIR__ . '/../src/news/Entry.php'; | |||
There was a problem hiding this comment.
require_once should also suffice, right?
There was a problem hiding this comment.
It's actually better (a second require/include would fail due to class is already defined).
kamil-tekiela
approved these changes
Jun 29, 2022
|
Thank you, @cmb69 and @kamil-tekiela! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
src/💁♂️ Given #579, it could make sense to start moving (and extracting additional) classes into
src/.Sooner or later we could even add auto-loading, instead of relying on
requirestatements.Examples of PSR-4 autoloader implementations can be found here.