Skip to content

Enhancement: Use autoloader #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2022
Merged

Enhancement: Use autoloader #614

merged 1 commit into from
Jul 8, 2022

Conversation

localheinz
Copy link
Contributor

This pull request

  • uses the autoloader in tests

Follows #604.
Follows #606.

@localheinz
Copy link
Contributor Author

Ha, looks like @kamil-tekiela suggests the same changes in #594.

kamil-tekiela
kamil-tekiela approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@kamil-tekiela kamil-tekiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but the tests should work even without autoloader which is why I only made this change as part of my PR.

@localheinz
Copy link
Contributor Author

@kamil-tekiela

This is fine, but the tests should work even without autoloader which is why I only made this change as part of my PR.

But why not use the autoloader in tests?

@kamil-tekiela
Copy link
Member

I only did it as part of the other PR to avoid merge conflicts, but since you proposed it here, let's merge it.

@kamil-tekiela kamil-tekiela merged commit 46477db into php:master Jul 8, 2022
@localheinz localheinz deleted the feature/autoloader branch July 8, 2022 22:08
@localheinz
Copy link
Contributor Author

Thank you, @kamil-tekiela!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil-tekiela kamil-tekiela kamil-tekiela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@localheinz @kamil-tekiela