Fix: Move and rename tests #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
commented
Jul 8, 2022
| @@ -4,7 +4,7 @@ sort some notes | |||
| precision=-1 | |||
| --FILE-- | |||
| <?php | |||
| require_once __DIR__ . "/../autoload.php"; | |||
| require_once __DIR__ . "/../../../autoload.php"; | |||
There was a problem hiding this comment.
If we used phpunit/phpunit, I would create a test for phpweb/UserNotes/Sorter in one of
phpweb/Test/UserNotes/SorterTestphpweb/Test/Unit/UserNotes/SorterTest
to have some sort of 1:1 mapping of class and test case.
Does that make sense?
|
How about using more descriptive file names? |
kamil-tekiela
approved these changes
Jul 9, 2022
|
Thank you, @kamil-tekiela! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
Follows #606.