CS update after upstream changes #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix the name and description to prevent confusion between the project ruleset and the organisation ruleset. * Set the minimum PHP version for the PHPCompatibility standard. * Ignore two PHPCompatibility non-issues. * Don't require property type declarations. * Ensure special characters used as literals in an exclude pattern are escaped.
|
Looks like there is one autofix round missing for |
|
@jaapio Yup... little weird as the build passed locally, but then again, some of the local installs I have of the coding standards may be out of date. Will have a look. |
Apparently Doctrine wants the related `@psalm` annotations to be grouped with the `@param` or `@return` tags.
|
Looks like there was a hick-up in the GHA run. @jaapio Could you restart the build ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPCS ruleset: update ruleset for upstream changes
CS: no whitespace before return type colon
CS: blank line between different use statement types
CS: import all things
CS: miscellaneous other whitespace fixes