-
-
Notifications
You must be signed in to change notification settings - Fork 50
Add list pseudo-type #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add list pseudo-type #136
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/** | ||
* This file is part of phpDocumentor. | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
* | ||
* @link http://phpdoc.org | ||
*/ | ||
|
||
namespace phpDocumentor\Reflection\PseudoTypes; | ||
|
||
use phpDocumentor\Reflection\PseudoType; | ||
use phpDocumentor\Reflection\Type; | ||
use phpDocumentor\Reflection\Types\Array_; | ||
use phpDocumentor\Reflection\Types\Integer; | ||
use phpDocumentor\Reflection\Types\Mixed_; | ||
|
||
/** | ||
* Value Object representing the type 'list'. | ||
* | ||
* @psalm-immutable | ||
*/ | ||
final class List_ extends Array_ implements PseudoType | ||
{ | ||
public function underlyingType(): Type | ||
{ | ||
return new Array_(); | ||
} | ||
|
||
public function __construct(?Type $valueType = null) | ||
{ | ||
parent::__construct($valueType, new Integer()); | ||
} | ||
|
||
/** | ||
* Returns a rendered output of the Type as it would be used in a DocBlock. | ||
*/ | ||
public function __toString(): string | ||
{ | ||
if ($this->valueType instanceof Mixed_) { | ||
return 'list'; | ||
} | ||
|
||
return 'list<' . $this->valueType . '>'; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,6 @@ | |
* | ||
* @psalm-immutable | ||
*/ | ||
final class Array_ extends AbstractList | ||
class Array_ extends AbstractList | ||
{ | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/** | ||
* This file is part of phpDocumentor. | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
* | ||
* @link http://phpdoc.org | ||
*/ | ||
|
||
namespace phpDocumentor\Reflection\PseudoTypes; | ||
|
||
use phpDocumentor\Reflection\Types\Compound; | ||
use phpDocumentor\Reflection\Types\Integer; | ||
use phpDocumentor\Reflection\Types\Mixed_; | ||
use phpDocumentor\Reflection\Types\String_; | ||
use PHPUnit\Framework\TestCase; | ||
|
||
/** | ||
* @coversDefaultClass \phpDocumentor\Reflection\PseudoTypes\List_ | ||
*/ | ||
class ListTest extends TestCase | ||
{ | ||
/** | ||
* @dataProvider provideArrays | ||
* @covers ::__toString | ||
*/ | ||
public function testArrayStringifyCorrectly(List_ $array, string $expectedString): void | ||
{ | ||
$this->assertSame($expectedString, (string) $array); | ||
} | ||
|
||
/** | ||
* @return mixed[] | ||
*/ | ||
public function provideArrays(): array | ||
{ | ||
return [ | ||
'simple list' => [new List_(), 'list'], | ||
'list of mixed' => [new List_(new Mixed_()), 'list'], | ||
'list of single type' => [new List_(new String_()), 'list<string>'], | ||
'list of compound type' => [new List_(new Compound([new Integer(), new String_()])), 'list<int|string>'], | ||
]; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.