Added support for class-string and class-string<Type> types

[othercorey]

This adds support for parsing class-string and class-string<Type>.

[mvriel]

What is class-string? I saw a reference to it in Psalm but couldn't quickly figure out what it does. My first gut instinct says it is an alias for self; which makes me wonder why to introduce a new type.

I try to err on the safe side introducing new types as each 'special' type can cause a conflict in people's codebases.

Can you provide a bit of background for this change?

[othercorey]

This is annotation supported by many static analyzers like phpstan/psalm/etc. It identifies string types that can only represent class names.

TypeResolver::class

[mvriel]

I just did some research and found Psalm and PHPStan to provide quite a few more pseudo-types. This does mean we may need to re-evaluate how to deal with an increasing amount of potentially conflicting pseudo-types.

I need to check whether pseudo-types currently take precedence to the imports/uses in the Context information; because if we are to add more of these it is good to declare that an import takes precedence over a pseudo-type.

I don't have the availability to do that at this moment, I will get back to this as soon as I can

[orklah]

I need to check whether pseudo-types currently take precedence to the imports/uses in the Context information; because if we are to add more of these it is good to declare that an import takes precedence over a pseudo-type.

I believe they solved this issue by adding a "-" in most pseudo types making them incompatible with actual imports.

[mvriel]

Yes, indeed. Though I am not sure whether the type resolver automatically behaves in the same way. The TypeResolver was written to be more flexible than PHP itself to better support pseudo-types :)

[mvriel]

Just checked everything and this is a-ok! Thanks for your patience