-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Shorthand supports for dash-core-components #1747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
90 commits
Select commit
Hold shift + click to select a range
97789e7
update Checklist, Dropdown, RangeSlider to accept optional shorthands
c4cedfe
update Checklist, RadioItems - added inline props and shorthand optio…
aee8ebd
fill component id if not given
3614b69
fix Dropdown props to accept array of string
bf43845
remove comments
4875ab9
fix lint issues
9deee71
generating seed for component id
effc6ef
Merge pull request #1 from workaholicpanda/feat/component-id-auto-fill
workaholicAB ab3dfae
lint fix in dash-table
e986f5d
lint fix
405bf72
remove inline props and lint fix
37a34c7
broken eslint :grimacing:
2582056
prettier fix
82ef2b7
set random id inside dash dependency
7cde3a6
Merge pull request #2 from workaholicpanda/dcc/set-random-id
workaholicAB 1c1faf2
lint fixes
38ed9bf
bug fix
49cbaa2
add inline styling support
c4c54bc
fix bugs
6b1b4b5
add column populating in dash-table
e172ef8
disable restricting dependency type
c443e67
fix radio options type check
286ace8
add comments to inline props
bd7a9e3
add tests for shorthands
e5335ce
remove unused imports
22d2020
remove tests, refactor assign
7497eb2
use ramda.type instead of typeof
cdd6d18
backup commit
df24223
add auto generating marks to RangeSlider & Slider
74c25af
add number support for shorthanded options - Checklist, Dropdown
4a10694
some refactor to get react-docgen working, slider props re-arrange
5ab6618
fix unit test - remove outdated part
d90461e
update props comment
workaholicAB 63ced02
fix feedback comments
f990b43
fix some issues in Checklist, DataTable props
f3e7893
pylint fix
67d0836
Apply suggestions from code review
workaholicAB 6188289
copy paste ProTypes to get doc-gen working
f7fd107
Merge commit
1d4479d
Test Slider and RangeSlider shorthand properties
akksi 1add4e2
Test Dropdown shorthand properties
akksi becdba9
Remove unnecessary imports
akksi 9fe2f78
random seed moved out to global scope, the test for set_random_id was…
cf0ebb5
Merge pull request #3 from workaholicpanda/dcc/fix-issue960-tests
workaholicAB 20d79c1
fix slider markers - respect steps given
f8bdf26
assert comparision is fixed
f052bbd
fix slider issues
348c88f
Merge branch 'dcc/fix-issue960' into dcc/fix-issue960-tests
akksi 83cea43
Add dropdown option sanitization to some additional required places
akksi 2ba81c6
Convert labels to strings when an Ojbect is passed as options
akksi 780bc32
Add more variants to Dropdown shorthand test
akksi 4d4b07e
Extend Slider tests
akksi 21b3bc6
Add test for Dropdown array value type
akksi f06fe08
Merge pull request #4 from akksi/dcc/fix-issue960-tests
workaholicAB a440ec6
fix: update inline description & style
8519619
chore: pass black format
45cded7
chore: react doc-gen fix & flake fix
c922427
chore: rename test file names to avoid conflict
6727574
Handle undefined options in Dropdown
akksi 6ecb2bc
Merge branch 'dcc/fix-issue960' into dcc/fix-issue960-tests
akksi 4ac85da
Merge pull request #5 from akksi/dcc/fix-issue960-tests
workaholicAB 7d85f2b
fix: the case when truncated out input marks handled
f835c0f
fix: correct step calculations implemented for sliders
8e5e6cf
fix: removed Start and End prefix / suffix from labels on Slider
5f569c9
chore: add labels to dropdown tests
d6e994a
chore: lint fix
d47a0b2
fix: dropdown options for test
24f6cd5
chore: prettier :sleepy:
d022d2b
fix: removed a test file which was causing percy tests fail
9ccdec3
fix: defining emptiness of dictionary implemented correctly, which fi…
edaea38
fix: omit 'step' from props
e54495e
chore: update props description
c8947e7
chore: remove unnecessary prop type checker
9485e50
fix: range slider test corrected, formatted to have some margins
a39a24e
Merge branch 'dcc/fix-issue960' of github.com:workaholicpanda/dash in…
07edc14
fix: the test_ddsh001_dropdown_shorthand_properties test restored bac…
ab8f4fb
fix: added bool type to CheckList label/value and RadioItem label/value
12e96e2
fix: the edited JS files are reformatted using lint
e49d34b
feat: implemented SI Units format for unit values of slider
487717b
feat: added tests to cover slider SI Units format for unit values
362929d
chore: eslint fix
1e7011e
fix: the test adopted to propsTypes which now accepts bool for severa…
9d77277
Merge branch 'dev' of github.com:plotly/dash into dcc/fix-issue960
6153bd0
fix: slider numbers whose ten factor is less than 3 and bigger than -…
a3e78b1
fix: lint issue fixed
23f5e79
fix: explicit null prevents auto generating marks in sliders
13e008f
fix: add snapshot for set_auto_id dependency link and asserts
d34453f
fix: test marks=None and SI units format
bea6c4c
fix: test_persistence - give step=1 to expect integer value output, o…
edf6042
fix: checking RadioItems and Checklist to accept new propTypes added …
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.