Skip to content

Bug fix - do not display empty bars when line.width is zero #4056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2019
Merged

Bug fix - do not display empty bars when line.width is zero #4056

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60f71a1
fix 4047 display empty bars only when having line.width
archmoj Jul 17, 2019
9d4a4bf
use getLineWidth function to get line width
archmoj Jul 17, 2019
3ee7dbf
declare new mergeArray options in Lib and use them in bar
archmoj Jul 18, 2019
579a1b5
remove unused Lib.mergeArrayCastNumber and Lib.mergeArrayCastIfNumber…
archmoj Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions src/traces/bar/plot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function plot(gd, plotinfo, cdModule, traceLayer, opts) {
var isWaterfall = (trace.type === 'waterfall');
var isFunnel = (trace.type === 'funnel');
var isBar = (trace.type === 'bar');
var shouldDisplayZeros = isBar || isFunnel;
var shouldDisplayZeros = (isBar || isFunnel);

var adjustPixel = 0;
if(isWaterfall && trace.connector.visible && trace.connector.mode === 'between') {
Expand Down Expand Up @@ -102,12 +102,23 @@ function plot(gd, plotinfo, cdModule, traceLayer, opts) {
var y0 = xy[1][0];
var y1 = xy[1][1];

var isBlank = di.isBlank = !(
isNumeric(x0) && isNumeric(x1) &&
isNumeric(y0) && isNumeric(y1) &&
(x0 !== x1 || (shouldDisplayZeros && isHorizontal)) &&
(y0 !== y1 || (shouldDisplayZeros && !isHorizontal))
var isBlank = (
x0 === x1 ||
y0 === y1 ||
!isNumeric(x0) ||
!isNumeric(x1) ||
!isNumeric(y0) ||
!isNumeric(y1)
);
// display zeros if line.width > 0
if(isBlank && shouldDisplayZeros) {
if(isHorizontal ? x1 - x0 === 0 : y1 - y0 === 0) {
if(di.mlw || trace.marker.line.width > 0) {
isBlank = false;
}
}
}
di.isBlank = isBlank;

// in waterfall mode `between` we need to adjust bar end points to match the connector width
if(adjustPixel) {
Expand Down
Binary file added test/image/baselines/bar_display_height_zero_only_line_width.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
340 changes: 340 additions & 0 deletions test/image/mocks/bar_display_height_zero_only_line_width.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,340 @@
{
"data": [
{
"type": "bar",
"marker": {
"line": {
"width": 0
}
},
"x": [
"A",
"b",
"c",
"d",
"E"
],
"y": [
0,
0,
null,
null,
1
],
"text": [
0,
0,
null,
null,
1
],
"textposition": "auto",
"insidetextanchor": "middle",
"cliponaxis": false
},
{
"type": "bar",
"marker": {
"line": {
"width": [10, 0, 10, 0, 10]
}
},
"x": [
"A",
"b",
"c",
"d",
"E"
],
"y": [
0,
0,
null,
null,
1
],
"text": [
0,
0,
null,
null,
1
],
"textposition": "auto",
"insidetextanchor": "middle",
"cliponaxis": false
},
{
"type": "bar",
"marker": {
"line": {
"width": 0
}
},
"x": [
"A",
"b",
"c",
"d",
"E"
],
"y": [
0,
0,
null,
null,
1
],
"text": [
0,
0,
null,
null,
1
],
"textposition": "auto",
"insidetextanchor": "middle",
"cliponaxis": false,
"xaxis": "x2",
"yaxis": "y2"
},
{
"type": "bar",
"marker": {
"line": {
"width": [10, 0, 10, 0, 10]
}
},
"x": [
"A",
"b",
"c",
"d",
"E"
],
"y": [
0,
0,
null,
null,
1
],
"text": [
0,
0,
null,
null,
1
],
"textposition": "auto",
"insidetextanchor": "middle",
"cliponaxis": false,
"xaxis": "x2",
"yaxis": "y2"
},
{
"type": "bar",
"marker": {
"line": {
"width": 0
}
},
"orientation": "h",
"y": [
"A",
"b",
"c",
"d",
"E"
],
"x": [
0,
0,
null,
null,
1
],
"text": [
0,
0,
null,
null,
1
],
"textposition": "auto",
"insidetextanchor": "middle",
"cliponaxis": false,
"xaxis": "x3",
"yaxis": "y3"
},
{
"type": "bar",
"marker": {
"line": {
"width": [10, 0, 10, 0, 10]
}
},
"orientation": "h",
"y": [
"A",
"b",
"c",
"d",
"E"
],
"x": [
0,
0,
null,
null,
1
],
"text": [
0,
0,
null,
null,
1
],
"textposition": "auto",
"insidetextanchor": "middle",
"cliponaxis": false,
"xaxis": "x3",
"yaxis": "y3"
},
{
"type": "bar",
"marker": {
"line": {
"width": 0
}
},
"orientation": "h",
"y": [
"A",
"b",
"c",
"d",
"E"
],
"x": [
0,
0,
null,
null,
1
],
"text": [
0,
0,
null,
null,
1
],
"textposition": "auto",
"insidetextanchor": "middle",
"cliponaxis": false,
"xaxis": "x4",
"yaxis": "y4"
},
{
"type": "bar",
"marker": {
"line": {
"width": [10, 0, 10, 0, 10]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this mock only has array marker.line.width value. Could you add one trace that test scaler marker.line.width?

Maybe you can leave this mock alone and simply add another mock using https://codepen.io/MojtabaSamimi/pen/bXbmba , so that we also test the relative-stacked case.

}
},
"orientation": "h",
"y": [
"A",
"b",
"c",
"d",
"E"
],
"x": [
0,
0,
null,
null,
1
],
"text": [
0,
0,
null,
null,
1
],
"textposition": "auto",
"insidetextanchor": "middle",
"cliponaxis": false,
"xaxis": "x4",
"yaxis": "y4"
}
],
"layout": {
"showlegend": true,
"width": 800,
"height": 800,
"dragmode": "pan",
"xaxis": {
"domain": [
0,
0.48
]
},
"xaxis2": {
"autorange": "reversed",
"anchor": "y2",
"domain": [
0.52,
1
]
},
"xaxis3": {
"anchor": "y3",
"domain": [
0,
0.48
]
},
"xaxis4": {
"autorange": "reversed",
"anchor": "y4",
"domain": [
0.52,
1
]
},
"yaxis": {
"domain": [
0,
0.48
]
},
"yaxis2": {
"autorange": "reversed",
"anchor": "x2",
"domain": [
0.52,
1
]
},
"yaxis3": {
"anchor": "x3",
"domain": [
0.52,
1
]
},
"yaxis4": {
"autorange": "reversed",
"anchor": "x4",
"domain": [
0,
0.48
]
}
}
}