Skip to content

export colors only once #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2020
Merged

export colors only once #2540

merged 1 commit into from
Jun 8, 2020

Conversation

nicolaskruchten
Copy link
Contributor

This should be a no-op but still good to clean up, right?

@nicolaskruchten nicolaskruchten requested a review from jonmmease June 5, 2020 12:58
@nicolaskruchten nicolaskruchten added this to the 4.8.2 milestone Jun 5, 2020
@jonmmease
Copy link
Contributor

Doesn't this change mean that this won't work any more?

import plotly
plotly.colors

@nicolaskruchten
Copy link
Contributor Author

No I don't think so... if you look two lines up from each of the deleted lines we're already importing/exporting these. I assume this is a copy-paste thing rather than intentional?

@jonmmease
Copy link
Contributor

Ohhh, yeah I see it now 🙂 💃

@nicolaskruchten nicolaskruchten merged commit 3a711e9 into master Jun 8, 2020
@nicolaskruchten nicolaskruchten deleted the import_cleanup branch June 19, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants