fix config settings and add the rest of plot options to config #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- why is get_plot_options in the root namespace? its name is so misleading - _plot_option_logic is the function that actually sets the options - make the precedence *extremely* clear. - make the world_readable + sharing dependency explicit - update the variable names: what was "current"? what was "plot_options". it's now `user_plot_options` - stuff that the user supplied and `plot_options_from_call_signature` - stuff that pass through from iplot, plot
we're now writing the default arguments to the disk. But we're also using `DEFAULT_PLOT_OPTIONS` in the namespace for updating `plot_options`.
now that the `_plot_option_option` logic is nice n generic, let's add some more options.
that's why we have session, right?
|
@chriddyp cool, got some comments for ya. I think it's good that you're looking into this refactor. It's definitely confusing and got much more so when we added some of the 'sharing' stuff in a recent pr. Another thing that would be nice... i think we need to reorganize the python api files. here are a couple things that jump out:
|
- why is get_plot_options in the root namespace? its name is so misleading - _plot_option_logic is the function that actually sets the options - make the precedence *extremely* clear. - make the world_readable + sharing dependency explicit - update the variable names: what was "current"? what was "plot_options". it's now `user_plot_options` - stuff that the user supplied and `plot_options_from_call_signature` - stuff that pass through from iplot, plot
we're now writing the default arguments to the disk. But we're also using `DEFAULT_PLOT_OPTIONS` in the namespace for updating `plot_options`.
now that the `_plot_option_option` logic is nice n generic, let's add some more options.
that's why we have session, right?
|
alright @theengineear - this one's for you: 4d367ab good to 💃 ? |
|
alright @theengineear - tests are fixed. |
| - You can also save `auto_open` and `sharing` to the config file so that you can forget these | ||
| keyword argument in `py.iplot` and `py.plot`. | ||
|
|
||
|
|
There was a problem hiding this comment.
oops, after praising the changelog, i totally didn't add a note! gah!
Also, this should now be 1.8.6, the update hit at 1.8.5, mind giving it a quick change?
|
@chriddyp looks good!
Other than that 💃 :) |
chriddyp
added a commit
that referenced
this pull request
Sep 30, 2015
fix config settings and add the rest of plot options to config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey @theengineear @cldougl can you take a look at this? I found the previous plot_option code super confusing to navigate, so I rewrote a bunch of it. Also, I added a ton of tests.
this fixes #302