This repository was archived by the owner on Oct 1, 2019. It is now read-only.
Add support for comments #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 26, 2017
Merged
This wires up the comment logic from prettier. This needs some modification inside of prettier itself, so it won't work as is. - locStart/End is ast-specific, we need a way to set it up for each parser. In this case I reused on that already existed: https://github.com/prettier/prettier/blob/master/src/util.js#L260-L262 - getSortedChildNodes as well, need a way to traverse the ast: https://github.com/prettier/prettier/blob/master/src/comments.js#L38 ```js (node.kind && node.kind !== "Comment") || node.ast_type && node.ast_type !== "comment") // <-- added ) { ``` - printComments as well: https://github.com/prettier/prettier/blob/master/src/comments.js#L928-L929 ```js switch (comment.type || comment.kind || comment.ast_type) { case "comment": return comment.value; case "Comment": ``` If we tweak those two small things in prettier itself, then it's able to print comments using the heuristic. @azz, do you think you'd be able to extract those out to be parser-specific?
taion
reviewed
Dec 26, 2017
| # a | ||
| ) | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| if a: # a |
There was a problem hiding this comment.
This isn't quite correct. PEP 8 calls for two spaces before inline comments.
There was a problem hiding this comment.
This is an odd requirement :)
There was a problem hiding this comment.
See https://www.python.org/dev/peps/pep-0008/#inline-comments
Inline comments should be separated by at least two spaces from the statement.
Yes, it's sort of weird, but it's more or less universal in Python-land.
taion
reviewed
Dec 26, 2017
| 'value': token.string, | ||
| 'start': token.startpos, | ||
| 'end': token.endpos, | ||
| } for token in atok.tokens if token.type == 57] |
There was a problem hiding this comment.
should be tokenize.COMMENT, which is 53 on py2
This was referenced Jan 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wires up the comment logic from prettier. This needs some modification inside of prettier itself, so it won't work as is.
locStart/End is ast-specific, we need a way to set it up for each parser. In this case I reused on that already existed: https://github.com/prettier/prettier/blob/master/src/util.js#L260-L262
getSortedChildNodes as well, need a way to traverse the ast: https://github.com/prettier/prettier/blob/master/src/comments.js#L38
If we tweak those two small things in prettier itself, then it's able to print comments using the heuristic. @azz, do you think you'd be able to extract those out to be parser-specific?