Skip to content

Core AndroidX support and creation of distributions for JCentre #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 1, 2021
Merged

Core AndroidX support and creation of distributions for JCentre #616

merged 11 commits into from
Jan 1, 2021

Conversation

rupeshkumar22
Copy link
Contributor

The PR adds the creation of AndroidX distributions for android processing core. It is the initiation of migrating Android Mode and PDE to use AndroidX build. The PR will not intervene in the Android Mode in any way. Gradle build in the root directory will be creating the following distributions -

  • core-androidx/dist/processing-core-androidx-1.1.1.jar
  • core-androidx/dist/processing-core-androidx-1.1.1.jar.md5
  • core-androidx/dist/processing-core-androidx-1.1.1.pom
  • core-androidx/dist/processing-core-androidx-1.1.1-sources.jar

Some of the AndroidX variables are defined in mode/version.properties and mode/mode.properties to use in build.gradle and core-androidx/build.gradle files. The directory core-androidx/src/assets remains same as core/src/assets.
An Example androidx project shows the use of core-androidx/dist/processing-core-androidx-1.1.1.jar. with the latest platform target API Level 30.
For now, the current PR does not include any code to copy zip in Android Mode nor it includes code to publish distributions. Some TODO tasks are defined in the core-androidx/build.gradle file.

@rupeshkumar22 rupeshkumar22 changed the title core-androidx support and creation of distributions for JCentre Core AndroidX support and creation of distributions for JCentre Dec 24, 2020
@rupeshkumar22
Copy link
Contributor Author

@codeanticode If you would like to review? Will it be better to include AndroidX for android mode and PDE? I think there is no support for android support libraries after Android Platform 28.

@codeanticode
Copy link
Contributor

@rupesh-kumar-lpu Hi Rupesh, thanks a lot for your contribution! I just started doing some belated work on the AndroidX port in this branch. I will now review your PR, however, after a cursory glance looks like you have created a separate version for the core library using the AndroidX libraries, is that right? I'd rather have a single version for maintenance reasons. If that's the case, we should still be able to run Processing sketches on devices running older versions of Android, shouldn't we?

@rupeshkumar22
Copy link
Contributor Author

@codeanticode You are right I was into providing a separate version for the AndroidX library. Good to know that the work is already in progress in another branch. I totally agree with your point that It is good to have a single version of android support for now in master. It will be better not to merge this request. Thanks!

Updating forked androidx branch
Revert "Updating forked androidx branch" By mistake updated master forked instead androidx branch forked
@rupeshkumar22
Copy link
Contributor Author

reverted the wrong commits to the forked master branch in case the request will be reviewed

@codeanticode codeanticode changed the base branch from master to androidx January 1, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants